Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

닉네임 변경 페이지 추가 #272

Merged
merged 7 commits into from
Oct 10, 2023

Conversation

ddyeon
Copy link
Member

@ddyeon ddyeon commented Oct 5, 2023

🔥 관련 이슈

close #271

🔥 PR Point

  • 마이페이지 아이콘 및 네비게이션 로직 추가
  • 기존 닉네임 설정 페이지 재활용 및 로직 수정

🔥 To Reviewers

기존 닉네임 설정 페이지 활용해서 만들었습니다.
API는 현재 개발버전에만 배포되어있어서 실행할 때 주소값 NetworkModule에서 변경하고 실행해야해요!
(이 부분은 추가로 개발/상용버전 BuildType 나누도록 합시다~!)

📷 Screenshot

기능 스크린샷
닉네임 변경 https://github.com/mash-up-kr/TwoToo_Android/assets/53086454/6581800a-9fb3-4dae-9388-c582f779fe4d

@ddyeon ddyeon requested review from hj1115hj and 014967 and removed request for hj1115hj October 5, 2023 13:29
@ddyeon ddyeon self-assigned this Oct 5, 2023
@ddyeon ddyeon added the feature feature label label Oct 5, 2023
@ddyeon ddyeon requested a review from hj1115hj October 8, 2023 14:03
Copy link
Collaborator

@hj1115hj hj1115hj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Contributor

@014967 014967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳

@014967 014967 merged commit 2f7e076 into mash-up-kr:develop Oct 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

닉네임 변경 기능 추가하기
3 participants