Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

인증사진을 줌하거나 저장하는 로직 추가 #267

Merged
merged 7 commits into from
Oct 10, 2023
Merged

인증사진을 줌하거나 저장하는 로직 추가 #267

merged 7 commits into from
Oct 10, 2023

Conversation

014967
Copy link
Contributor

@014967 014967 commented Oct 2, 2023 •
edited
Loading

🔥 관련 이슈

close #266

🔥 PR Point

  • 이미지 줌인 아웃 추가
  • 이미지 더블클릭시 줌인 스케일 초기화
  • 이미지저장 로직 추가
  • navigation에서 url형식으로 네비게이션할 경우 encoding로직추가
  • 이미지 디테일 스크린 추가

🔥 To Reviewers

Todo

  • 생각해보니 이미지 주소로 그대로 저장해서 변경해야할듯[아직안함]

📷 Screenshot

기능 스크린샷
이미지 저장 https://github.com/mash-up-kr/TwoToo_Android/assets/62296097/f53f556f-59a9-48b6-a838-344f40206a54

@014967 014967 requested review from hj1115hj and ddyeon October 2, 2023 07:43
ddyeon
ddyeon approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@ddyeon ddyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구웃!

presenter/src/main/java/com/mashup/twotoo/presenter/history/detailImage/DetailImageScreen.kt Show resolved Hide resolved
hj1115hj
hj1115hj approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@hj1115hj hj1115hj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

왕대박 신기한거 많이 배웠다 링크 남겨준거 고마옹!~~ 굿굿!!

presenter/src/main/java/com/mashup/twotoo/presenter/history/navigation/HistoryNavigation.kt Show resolved Hide resolved
presenter/src/main/java/com/mashup/twotoo/presenter/util/IncodingImageUrl.kt Show resolved Hide resolved
presenter/src/main/java/com/mashup/twotoo/presenter/util/IncodingImageUrl.kt Show resolved Hide resolved
@014967 014967 merged commit c65bcc9 into mash-up-kr:develop Oct 10, 2023
1 check passed
@014967 014967 deleted the feature/#issue_266 branch October 10, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddyeon ddyeon ddyeon approved these changes

@hj1115hj hj1115hj hj1115hj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

인증 사진을 줌 인하거나 저장할 수 있도록 변경
3 participants
@014967 @hj1115hj @ddyeon