Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

진행중인챌린지 히스토리에서는 이미지 변경하기 #264

Merged
merged 4 commits into from
Oct 10, 2023
Merged

진행중인챌린지 히스토리에서는 이미지 변경하기 #264

merged 4 commits into from
Oct 10, 2023

Conversation

014967
Copy link
Contributor

@014967 014967 commented Sep 21, 2023 •
edited
Loading

🔥 관련 이슈

close #261

🔥 PR Point

  • viewState에 따라서 분기 처리

🔥 To Reviewers

📷 Screenshot

기능 스크린샷
진행중 이미지 추가 스크린샷 2023-09-21 오후 10 01 18
진행중 이미지 추가 스크린샷 2023-09-21 오후 11 03 21

@014967 014967 self-assigned this Sep 21, 2023
ddyeon
ddyeon approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@ddyeon ddyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

presenter/src/main/java/com/mashup/twotoo/presenter/garden/GardenComponents.kt Outdated
contentScale = ContentScale.Fit,
previewPlaceholder = R.drawable.img_head_camellia_sm,
)
if (challengeCardInfoUiModel.viewState == "InProgress") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 위에 만들어둔 확장함수랑 통일해도 될 것 같아요~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddyeon 2ef0692 리뷰 고마웡 반영했엉

hj1115hj
hj1115hj approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@hj1115hj hj1115hj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

presenter/src/main/java/com/mashup/twotoo/presenter/garden/GardenComponents.kt
@@ -120,6 +125,10 @@ private fun ChallengeInfo(challengeCardInfoUiModel: ChallengeCardInfoUiModel) {
}
}

private fun String.isInProgress(): Boolean {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

공통 코드 빼는것 좋은거 같아요~ 멋졍! 👍

@014967 014967 merged commit 4b6af30 into mash-up-kr:develop Oct 10, 2023
1 check passed
@014967 014967 deleted the feature/#issue_261 branch October 10, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddyeon ddyeon ddyeon approved these changes

@hj1115hj hj1115hj hj1115hj approved these changes

@yoonhyekim yoonhyekim Awaiting requested review from yoonhyekim

Assignees

@014967 014967

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

진행중인챌린지 히스토리에서는 이미지 변경하기
3 participants
@014967 @hj1115hj @ddyeon