Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 검색결과와 마이페이지 밈 리스트뷰 디자인 수정 및 탭바 수정 #65

Merged
merged 5 commits into from
Aug 11, 2024

Conversation

hryeong66
Copy link
Collaborator

What is this PR? 🔍

이슈

설명

검색결과와 마이페이지 밈 리스트뷰 디자인 수정 및 탭바 수정

Changes 📝

  • 색결과와 마이페이지가 공통으로 사용하고 있는 memeListView를 디자인 수정
  • memeListView 복사 버튼 클릭시 popup view 뜨도록 수정
  • 탭바 디자인 수정
  • 탭바 로띠 적용했는데 로띠 파일이 이상한 것 같아서 확인 요청드렸습니다!

Screenshot 📸

Simulator Screen Recording - iPhone 15 Pro - 2024-08-08 at 19 23 19

To Reviewers 🙏

@hryeong66 hryeong66 added the 🏹 Fix 버그 수정 label Aug 8, 2024
@auto-assign auto-assign bot requested review from chansooo, jongnan and lina0322 August 8, 2024 10:27
}
.foregroundStyle(color)
.padding(40)
}

var tabImageView: some View {
ZStack {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기는 왜 ZStack이 있나용?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인 감사합니다!! ZStack은 이전에 기존 tabImage를 깔고 그 위에 로띠를 재생시키려고 했다가 삭제하지 않았던거라서 수정했습니다! abfee50

Comment on lines 73 to 74
.resizable()
.frame(width: 24, height: 24)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건 공통으로 빼내면 될꺼 같아요!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵! 확인감사합니다~ 수정했어요~! abfee50

@hryeong66 hryeong66 changed the base branch from feature/#51-mypage-hyerjang to develop August 11, 2024 12:42
@hryeong66 hryeong66 merged commit 255e844 into develop Aug 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏹 Fix 버그 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] 탭바 디자인 수정 [FIX] MemeListView 디자인 수정
2 participants