Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#28 feature] 네비게이션 추가 #43

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

Ahn-seokjoo
Copy link
Collaborator

개요

이슈 링크 혹은 PR 내용 요약

네비 추가했어요

작업 내용

실제 작업 내용

시연 화면 (option)

실행 스크린샷 혹은 영상 첨부

기능A 구현 기능B 구현 ...
...

To Reviers

리뷰어들에게 전할 말

Close

close #

@Ahn-seokjoo Ahn-seokjoo self-assigned this Jun 29, 2024
Copy link
Collaborator

@fbghgus123 fbghgus123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ahn-seokjoo
👍👍👍👍👍

@@ -0,0 +1,22 @@
package com.dorabangs.feature.navigation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ahn-seokjoo @ddyeon
진짜 패키지 이름 거시기 하긴 하다 ~~

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ

fun NavController.navigateToSaveLink(navOptions: NavOptions? = null) =
navigate(NavigationRoute.SaveLink.route, navOptions)

fun NavGraphBuilder.saveLinkNavigation(navController: NavHostController) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ahn-seokjoo
navController를 받는 게 아니라, 람다를 받아야 할 듯 ??

Copy link
Member

@ddyeon ddyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘했어여~
그때 해커톤때 말했던 방식도 좀 찾아보고 도전해보자~🍖

@Ahn-seokjoo Ahn-seokjoo merged commit e20c647 into develop Jul 1, 2024
2 checks passed
@Ahn-seokjoo Ahn-seokjoo deleted the feature/add_destination branch July 1, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants