[#28 feature] 텍스트 필드 추가 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbghgus123
approved these changes
Jun 29, 2024
| import com.mashup.dorabangs.core.designsystem.theme.ErrorLabelColorTokens | ||
|
|
||
| @Composable | ||
| fun DoraErrorLabel( |
There was a problem hiding this comment.
@Ahn-seokjoo
DoraTextFieldErrorLabel 해주면 안되나 ?
| import com.mashup.dorabangs.core.designsystem.theme.LabelColorTokens | ||
|
|
||
| @Composable | ||
| fun DoraLabel( |
There was a problem hiding this comment.
@Ahn-seokjoo
DoraTextFieldLabel 이라고 해주면 안되냐 ?!
Comment on lines
47
to
49
| val TextFieldBackGroundColor = DoraColorTokens.G1 | ||
| val TextFieldHintTextColor = DoraColorTokens.G4 | ||
| val TextFieldClearButtonColor = DoraColorTokens.G4 |
There was a problem hiding this comment.
여기 TextField 빼도 될듯??
object에 이미 네이밍됨
| val TextFieldClearButtonColor = DoraColorTokens.G4 | ||
| } | ||
|
|
||
| object LabelColorTokens { |
There was a problem hiding this comment.
여기는 Prefix에 TextField 추가하면 좋을 듯 ??
| @@ -7,4 +7,5 @@ | |||
| <string name="home_empty_feed">테스트 테스트 테스트 테스트</string> | |||
| <string name="snack_bar_title">클립보드에 복사한 링크 저장</string> | |||
| <string name="snack_bar_cancel_description">스낵바 취소</string> | |||
| <string name="url_text_clear">url 모두 지우기</string> | |||
There was a problem hiding this comment.
@Ahn-seokjoo
사용되는 곳을 prefix 붙여주셈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
텍스트 필드 추가
작업 내용
텍필 추가
에러 추가
라벨 추가
시연 화면 (option)
To Reviers
Close
close #