도라방스Topbar 제작기 #26
Merged
도라방스Topbar 제작기 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ahn-seokjoo
reviewed
Jun 19, 2024
| .padding(end = 20.dp) | ||
| .clickable { onClickActonIcon() }, | ||
| painter = painterResource(id = actionIcon), | ||
| contentDescription = null, |
Ahn-seokjoo
reviewed
Jun 19, 2024
| if (actionIcon != null) { | ||
| Icon( | ||
| modifier = | ||
| Modifier |
Ahn-seokjoo
reviewed
Jun 19, 2024
| import androidx.compose.ui.Alignment | ||
| import androidx.compose.ui.Modifier | ||
|
|
||
| object DorabangsTopBar : TopAppBarType { |
There was a problem hiding this comment.
투투에서 리팩토링할때 이렇게 햇는데 깔끔한거같아서 가져왔슴당~~!!
fbghgus123
approved these changes
Jun 19, 2024
| ) { | ||
| TopAppBar( | ||
| modifier = modifier, | ||
| colors = TopAppBarDefaults.topAppBarColors(containerColor = Color.White), |
There was a problem hiding this comment.
@ddyeon
머터리얼에 이런 것도 있구나
디자인 시스템 적용되면 바꾸긴 해야됨 ~~
Comment on lines
87
to
116
| @Preview | ||
| @Composable | ||
| fun PreviewBackNavigationTopBar() { | ||
| DorabangsTopBar.BackNavigationTopBar( | ||
| modifier = Modifier.fillMaxWidth(), | ||
| title = "Dorabangs", | ||
| titleAlignment = Alignment.CenterStart, | ||
| ) {} | ||
| } | ||
|
|
||
| @Preview | ||
| @Composable | ||
| fun PreviewBackWithActionIconTopBar() { | ||
| DorabangsTopBar.BackWithActionIconTopBar( | ||
| modifier = Modifier.fillMaxWidth(), | ||
| title = "Dorabangs", | ||
| actionIcon = R.drawable.ic_plus, | ||
| onClickBackIcon = {}, | ||
| onClickActonIcon = {}, | ||
| ) | ||
| } | ||
|
|
||
| @Preview | ||
| @Composable | ||
| fun PreviewTitleTopAppBar() { | ||
| DorabangsTopBar.TitleTopAppBar( | ||
| modifier = Modifier.fillMaxWidth(), | ||
| title = "Dorabangs", | ||
| ) | ||
| } |
There was a problem hiding this comment.
@ddyeon
프리뷰까지 추가한거 좋았다??
| import androidx.compose.ui.Alignment | ||
| import androidx.compose.ui.Modifier | ||
|
|
||
| object DorabangsTopBar : TopAppBarType { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
공통Topbar 제작
작업 내용
공통Topbar만들었습니다~!!! 이름은
DorabangsTopbar로 우선 해뒀는데맘에 안드면 앱이름으로 바꿉시당ㅎㅎ 아이콘도 미확정~~
TopAppBarType만들어서 4가지 타입별로 사용할 수 있게 해뒀는데 어떤가유?!!시연 화면 (option)
To Reviers
풀리퀘 템플릿 표가 왜이러지?!!! 구냥 넣음ㅎㅎ
Close
close #18