홈 화면 Post 캐싱 추가 #242
Merged
홈 화면 Post 캐싱 추가 #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ahn-seokjoo
reviewed
Oct 1, 2024
Comment on lines
+566
to
+572
| val posts = getLocalPostsUseCase(LOCAL_CACHED_POSTS_COUNT) | ||
|
|
||
| if (state.folderList.isEmpty()) { | ||
| initFolderList() | ||
| } | ||
|
|
||
| reduce { state.copy(postList = posts.items.toUIModel(state.folderList)) } |
There was a problem hiding this comment.
앱 처음 킬 때 이러케 대면 로컬도 캐싱된 리스트가 있고 state는 초기화 상태라서 initFolderList도 불리지않낭?
로컬, 리모트 둘다 부르는게 목적이지?
맞다면 reduce에 캐싱된 데이터에 리모트 데이터를 덮어쓰는건가 ?? 맞나?
There was a problem hiding this comment.
@Ahn-seokjoo
folderList는 둘 다 필요한데, 둘 중 어느 것이 먼저 불릴지 모르기 때문에 둘다 넣음.
캐싱된 데이터에 리모트 데이터 덮어 쓰는건 맞슴당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업 내용
시연 화면 (option)
REC-20241001223736.mp4
To Reviers
홈 화면에서 Posts 가져오는 로직을 그림으로 그렸습니다.
그림에 대한 간단한 설명을 드리자면,
이번 PR 에서는 스크롤 복구는 구현하지 않았습니다 ...
Close
close #