core모듈 재세팅 했슴당 #24
Merged
core모듈 재세팅 했슴당 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lint통과 왜케 어려운거야!!!!!!!!!!!!!!!!!! |
Ahn-seokjoo
reviewed
Jun 17, 2024
| @@ -0,0 +1 @@ | |||
| /build | |||
There was a problem hiding this comment.
Ahn-seokjoo
reviewed
Jun 17, 2024
| @@ -0,0 +1 @@ | |||
| /build | |||
Ahn-seokjoo
reviewed
Jun 17, 2024
Comment on lines
+3
to
+4
| import org.junit.Assert.assertEquals | ||
| import org.junit.Test |
Ahn-seokjoo
approved these changes
Jun 17, 2024
fbghgus123
approved these changes
Jun 18, 2024
| } | ||
| } | ||
|
|
||
| fun CoroutineScope.doraLaunch(block: suspend CoroutineScope.() -> Unit) = |
Comment on lines
+6
to
+33
| android { | ||
| namespace = "com.mashup.dorabangs.core.coroutine" | ||
| compileSdk = 34 | ||
|
|
||
| defaultConfig { | ||
| minSdk = 24 | ||
|
|
||
| testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner" | ||
| consumerProguardFiles("consumer-rules.pro") | ||
| } | ||
|
|
||
| buildTypes { | ||
| release { | ||
| isMinifyEnabled = false | ||
| proguardFiles( | ||
| getDefaultProguardFile("proguard-android-optimize.txt"), | ||
| "proguard-rules.pro", | ||
| ) | ||
| } | ||
| } | ||
| compileOptions { | ||
| sourceCompatibility = JavaVersion.VERSION_18 | ||
| targetCompatibility = JavaVersion.VERSION_18 | ||
| } | ||
| kotlinOptions { | ||
| jvmTarget = "18" | ||
| } | ||
| } |
There was a problem hiding this comment.
이런거 묶어서 한 번에 관리해주는 그런게 있엇던 것 같은데 나중에 찾아서 넣어볼게 ~
오빠가 잠들었을 때 그렇게 하기로 했어. 기존에 보여줬던 증분모듈 레퍼런스 참고해보니 core모듈도 쪼개서 필요한 부분에다 가져다 쓰더라구! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
core 모듈도 모듈로 다시 분리했어유~!
작업 내용
시연 화면 (option)
To Reviers
디자인시스템모듈에 component랑 theme 패키지 우선 만들었어요~!
component에 공통 컴포넌트들 쓰면 될 것 같아서 우선 예시파일로 하나 넣어뒀슴당
Close
close#