Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

홈 화면 로딩 관련 개선 #232

Merged
merged 2 commits into from
Sep 27, 2024
Merged

홈 화면 로딩 관련 개선 #232

merged 2 commits into from
Sep 27, 2024

Conversation

fbghgus123
Copy link
Collaborator

개요

이슈 링크 혹은 PR 내용 요약

  • 홈 화면 로딩 관련 개선

작업 내용

실제 작업 내용

  • 홈 화면 로딩 lottie 무한 반복 설정
  • 폴더 로딩 전 기본 폴더 보여지도록 설정

시연 화면 (option)

실행 스크린샷 혹은 영상 첨부

로딩중인 홈화면
image

To Reviers

리뷰어들에게 전할 말

  • 도라핑 화이핑

@@ -60,8 +61,21 @@ sealed interface FeedUiModel {
val title: String = "",
val postCount: Int = 0,
val folderId: String = "",
@DrawableRes val icon: Int? = com.mashup.dorabangs.core.designsystem.R.drawable.ic_3d_all_small,
@DrawableRes val icon: Int? = CR.drawable.ic_3d_all_small,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR7 ㄷㄷ;

Copy link
Collaborator

@Ahn-seokjoo Ahn-seokjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SIU~

Copy link
Member

@ddyeon ddyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

왓~

@fbghgus123 fbghgus123 merged commit fd647e3 into develop Sep 27, 2024
4 checks passed
@fbghgus123 fbghgus123 deleted the feature/loading branch September 27, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants