로띠 스플래시 액티비티 추가 #231
Merged
로띠 스플래시 액티비티 추가 #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddyeon
commented
Sep 23, 2024
Comment on lines
35
to
48
| val url = intent.data?.path?.substring(1).orEmpty() | ||
|
|
||
| installSplashScreen().apply { | ||
| setKeepOnScreenCondition { | ||
| (splashViewModel.isSplashShow.value || splashViewModel.firstEntryScreen.value == FirstEntryScreen.Splash) && | ||
| url.isBlank() | ||
| } |
There was a problem hiding this comment.
여기 기존에 url받아와서 그냥 비어있는지만 체크하던데,,무슨 기능인지 아는사람?
There was a problem hiding this comment.
스플래시 만든 사람이 모르면 우리도 몰라 !
There was a problem hiding this comment.
@ddyeon @Ahn-seokjoo
억울하오 억울하오
fbghgus123
approved these changes
Sep 24, 2024
Ahn-seokjoo
reviewed
Sep 25, 2024
| val firstEntryScreen = splashViewModel.firstEntryScreen.collectAsState() | ||
| if (firstEntryScreen.value != FirstEntryScreen.Splash) { | ||
| val imm = getSystemService(Context.INPUT_METHOD_SERVICE) as? InputMethodManager | ||
| firstEntryScreen?.let { |
There was a problem hiding this comment.
이거 firstEntryScreen null인 케이스가 있음? 있다면 빈 화면만 나올 것 같은뎅
Ahn-seokjoo
reviewed
Sep 25, 2024
| val userId = Settings.Secure.getString(contentResolver, Settings.Secure.ANDROID_ID) | ||
| splashViewModel.checkUserToken(userId) | ||
|
|
||
| val url = intent.data?.path?.substring(1).orEmpty() |
There was a problem hiding this comment.
웅 그래서 지우려고햇는데,, 기존에 main에 있떤 코드여서 위에서 물어본건데 아무도 모르면
지웁니다?
Ahn-seokjoo
reviewed
Sep 25, 2024
| splashShowFlow.value = false | ||
| _firstEntryScreen.value = if (getIsFirstEntryUseCase().firstOrNull() != false) FirstEntryScreen.Onboarding else FirstEntryScreen.Home | ||
| } else { | ||
| // Todo :: 유저 토큰 가져오기 실패에 대한 처리 해줘야함 (Like 토스트 메시지) |
Ahn-seokjoo
reviewed
Sep 25, 2024
| @@ -7,7 +7,7 @@ import com.mashup.dorabangs.domain.model.Folder | |||
| import com.mashup.dorabangs.domain.utils.isValidUrl | |||
|
|
|||
| data class HomeState( | |||
| val isLoading: Boolean = false, | |||
| val isLoading: Boolean = true, | |||
There was a problem hiding this comment.
false로 했더니 액티비티 전환 시 컴포저블 보이고 로딩 도는 이슈가 있어서 바꿨므당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업 내용
시연 화면 (option)
2024-09-23.11.20.03.mov
To Reviers
Close
close #