Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.4 배포 #213

Merged
merged 43 commits into from
Sep 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
47455bf
[chore] 폰트 디자인시스템 수정사항 반영
fbghgus123 Aug 30, 2024
a3cf108
Merge branch 'master' into develop
Ahn-seokjoo Aug 30, 2024
1986ebd
[feature] cd 추가
Ahn-seokjoo Aug 30, 2024
56b30bd
[feature] 오타 수정
Ahn-seokjoo Aug 30, 2024
178835f
[fix] userFraction 1.0 -> 1로 수정
Ahn-seokjoo Aug 30, 2024
548c51f
[fix] 그냥 user fraction 제거
Ahn-seokjoo Aug 30, 2024
d64b3d3
[feature] 조건 변경
Ahn-seokjoo Aug 30, 2024
a70df57
[feature] auto-tagging 로직 수정
Ahn-seokjoo Aug 30, 2024
00de637
[chore] 컬러 디자인시스템 변경 적용
fbghgus123 Aug 31, 2024
bd2003f
[chore] 카드 디자인 변경 적용
fbghgus123 Aug 31, 2024
44bc130
[chore] Dialog 디자인 변경 적용
fbghgus123 Aug 31, 2024
33fd427
[chore] 아이콘 디자인 시스템 변경 적용
fbghgus123 Sep 1, 2024
17f3208
[refactor] 버튼 디자인 수정
ddyeon Sep 2, 2024
4779ab6
[chore] 배너 디자인 변경 적용
fbghgus123 Sep 2, 2024
5951a16
[chore] trashbin 아이콘 수정
fbghgus123 Sep 2, 2024
45c112a
Merge pull request #199 from mash-up-kr/feature/refactoring/tagging
Ahn-seokjoo Sep 2, 2024
8d2a155
[refactor] 다이얼로그 버튼 색상 변경
ddyeon Sep 2, 2024
75be91e
Merge pull request #198 from mash-up-kr/feature/cd
Ahn-seokjoo Sep 2, 2024
95cbbbd
[fix] 홈화면 버튼 사이즈 수정
ddyeon Sep 2, 2024
d5187e3
[chore] Tap 디자인 변경 적용
fbghgus123 Sep 2, 2024
5fab61b
[refactor] Ai분류 버튼명 및 height 수정
ddyeon Sep 2, 2024
5093816
[chore] Tap Bar 디자인 변경 적용
fbghgus123 Sep 2, 2024
4623a02
[fix] 홈화면 버튼 사이즈 수정.
ddyeon Sep 2, 2024
43ef315
[chore] Top Bar 디자인 변경 적용
fbghgus123 Sep 2, 2024
886da8d
[feature] ai classification 디자인 수정
Ahn-seokjoo Sep 2, 2024
599af99
[chore] 리뷰 반영
fbghgus123 Sep 3, 2024
17f5f6e
Merge pull request #205 from mash-up-kr/feature/aiclassification/desi…
Ahn-seokjoo Sep 3, 2024
8aac839
Merge branch 'chore/design' into refator/button_design
ddyeon Sep 3, 2024
7e52584
Merge pull request #202 from mash-up-kr/refator/button_design
ddyeon Sep 3, 2024
3bd7839
Merge branch 'develop' into chore/design
ddyeon Sep 3, 2024
1f169b3
Merge pull request #204 from mash-up-kr/chore/design
ddyeon Sep 3, 2024
d3ea47e
[refactoring] project 확장함수로 변경
Ahn-seokjoo Sep 5, 2024
5397e78
[refactoring] 변경사항 반영
Ahn-seokjoo Sep 5, 2024
e62ca02
[refactoring] java version 17 gogo
Ahn-seokjoo Sep 5, 2024
cdefddf
[refactoring] ci build 17로 변경
Ahn-seokjoo Sep 5, 2024
d53cbf4
[feature] kapt -> ksp 마이그레이션
Ahn-seokjoo Sep 5, 2024
ed9b926
[fix] ksp 에러 해결
Ahn-seokjoo Sep 5, 2024
23519c8
[refactoring] 네이밍 변경 kotlin -> kotlinx
Ahn-seokjoo Sep 5, 2024
321abd0
Merge pull request #206 from mash-up-kr/feature/refactoring/project
Ahn-seokjoo Sep 6, 2024
3edb219
Merge pull request #207 from mash-up-kr/feature/java_version/down_grade
Ahn-seokjoo Sep 6, 2024
07eb39b
Merge pull request #208 from mash-up-kr/feature/remove_kapt
Ahn-seokjoo Sep 6, 2024
ada9bf8
test v1.0.4
ze-zeh Sep 7, 2024
837724a
Merge pull request #212 from mash-up-kr/version_up
Ahn-seokjoo Sep 7, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/auto-tagging.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:

jobs:
auto-tagging:
if: github.event.pull_request.merged == true
if: github.event.pull_request.merged == true && (contains(github.event.pull_request.labels.*.name, 'major') || contains(github.event.pull_request.labels.*.name, 'minor') || contains(github.event.pull_request.labels.*.name, 'patch'))
runs-on: ubuntu-latest

steps:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: set up JDK 18
- name: set up JDK 17
uses: actions/setup-java@v3
with:
java-version: '18'
java-version: '17'
distribution: 'temurin'
cache: 'gradle'
- name: Download common setup files
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
name: create artifact
name: create artifact and deployment
on:
workflow_dispatch:
pull_request:
branches:
- master
types:
- synchronize
- opened
- closed

jobs:
common_setup:
Expand All @@ -15,16 +14,17 @@ jobs:

upload_apk:
needs: common_setup
if: github.event.pull_request.merged == true
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- name: set up JDK 18
- name: set up JDK 17
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '18'
java-version: '17'
cache: 'gradle'

- name: Download common setup files
Expand Down Expand Up @@ -59,16 +59,17 @@ jobs:

upload_aab:
needs: common_setup
if: github.event.pull_request.merged == true
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- name: set up JDK 18
- name: set up JDK 17
uses: actions/setup-java@v3
with:
distribution: 'zulu'
java-version: '18'
java-version: '17'
cache: 'gradle'
- name: Download common setup files
uses: actions/download-artifact@v4
Expand Down Expand Up @@ -98,6 +99,14 @@ jobs:
retention-days: 7
overwrite: true

- name: play store auto deployment
uses: r0adkll/upload-google-play@v1
with:
packageName: com.mashup.dorabangs
releaseFiles: app/build/outputs/bundle/release/app-release.aab
track: production
serviceAccountJsonPlainText: ${{ secrets.SERVICE_ACCOUNT_JSON }}

post_github:
needs: [ upload_apk, upload_aab ]
runs-on: ubuntu-latest
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/lint_check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ jobs:

steps:
- uses: actions/checkout@v4
- name: set up JDK 18
- name: set up JDK 17
uses: actions/setup-java@v3
with:
java-version: '18'
java-version: '17'
distribution: 'temurin'
cache: 'gradle'

Expand Down
14 changes: 7 additions & 7 deletions app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ plugins {
alias(libs.plugins.com.android.application)
alias(libs.plugins.org.jetbrains.kotlin.android)
alias(libs.plugins.hilt)
alias(libs.plugins.kotlin.kapt)
alias(libs.plugins.ksp)
alias(libs.plugins.kotlinx.serialization)
alias(libs.plugins.google.gms.service)
}
Expand All @@ -17,7 +17,7 @@ android {
applicationId = "com.mashup.dorabangs"
minSdk = libs.versions.min.sdk.get().toInt()
targetSdk = libs.versions.target.sdk.get().toInt()
versionCode = GitUtil.getGitCommitCount(project)
versionCode = getGitCommitCount()
versionName = libs.versions.versionName.get()

testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
Expand Down Expand Up @@ -51,14 +51,14 @@ android {
}
}
compileOptions {
sourceCompatibility = JavaVersion.VERSION_18
targetCompatibility = JavaVersion.VERSION_18
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17
}
composeOptions {
kotlinCompilerExtensionVersion = "1.4.4"
kotlinCompilerExtensionVersion = "1.5.2"
}
kotlinOptions {
jvmTarget = "18"
jvmTarget = "17"
}
packaging {
resources {
Expand Down Expand Up @@ -101,7 +101,7 @@ dependencies {

// Hilt
implementation(libs.hilt.android)
kapt(libs.hilt.compiler)
ksp(libs.hilt.compiler)

// Firebase
implementation(platform(libs.firebase.bom))
Expand Down
2 changes: 1 addition & 1 deletion build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ plugins {
alias(libs.plugins.org.jetbrains.kotlin.jvm) apply false
alias(libs.plugins.spotless) apply true
alias(libs.plugins.hilt) apply false
alias(libs.plugins.kotlin.kapt) apply false
alias(libs.plugins.google.gms.service) apply false
alias(libs.plugins.ksp) apply false
}

subprojects {
Expand Down
32 changes: 15 additions & 17 deletions buildSrc/src/main/kotlin/GitUtil.kt
Original file line number Diff line number Diff line change
@@ -1,20 +1,18 @@
import java.io.ByteArrayOutputStream
import org.gradle.api.Project

object GitUtil {
/**
* 익셉션 나오면 1로 세팅돼서
* aab 업로드시에 버전이 겹치다고 나올 것임
* 그 때 default를 바꾸던,,익셉션 안나게 하던,,, 잘 해보도록 해~
*/
fun getGitCommitCount(project: Project): Int {
return runCatching {
val stdout = ByteArrayOutputStream()
project.exec {
commandLine = listOf("git", "rev-list", "--count", "HEAD")
standardOutput = stdout
}
stdout.toString().trim().toInt()
}.getOrDefault(1)
}
}
/**
* 익셉션 나오면 1로 세팅돼서
* aab 업로드시에 버전이 겹치다고 나올 것임
* 그 때 default를 바꾸던,,익셉션 안나게 하던,,, 잘 해보도록 해~
*/
fun Project.getGitCommitCount(): Int {
return runCatching {
val stdout = ByteArrayOutputStream()
project.exec {
commandLine = listOf("git", "rev-list", "--count", "HEAD")
standardOutput = stdout
}
stdout.toString().trim().toInt()
}.getOrDefault(1)
}
6 changes: 3 additions & 3 deletions core/coroutine/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ android {
}

compileOptions {
sourceCompatibility = JavaVersion.VERSION_18
targetCompatibility = JavaVersion.VERSION_18
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17
}
kotlinOptions {
jvmTarget = "18"
jvmTarget = "17"
}
}

Expand Down
8 changes: 4 additions & 4 deletions core/designsystem/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@ android {
compose = true
}
composeOptions {
kotlinCompilerExtensionVersion = "1.4.3"
kotlinCompilerExtensionVersion = "1.5.2"
}
compileOptions {
sourceCompatibility = JavaVersion.VERSION_18
targetCompatibility = JavaVersion.VERSION_18
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17
}
kotlinOptions {
jvmTarget = "18"
jvmTarget = "17"
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ object DoraBottomSheet : BottomSheetType {
icon = R.drawable.ic_add_folder_purple,
itemName = stringResource(id = R.string.moving_folder_dialog_add_folder),
isSelected = false,
color = DoraColorTokens.Primary,
color = DoraColorTokens.Primary500,
),
onClickItem = onClickCreateFolder,
isLastItem = false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,20 +16,20 @@ import androidx.compose.runtime.Composable
import androidx.compose.runtime.remember
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Brush
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.graphics.Shape
import androidx.compose.ui.unit.dp
import com.mashup.dorabangs.core.designsystem.theme.DoraColorTokens

@Composable
fun GradientButton(
fun BannerButton(
onClick: () -> Unit,
modifier: Modifier = Modifier,
gradientModifier: Modifier = Modifier,
enabled: Boolean = true,
shape: Shape = ButtonDefaults.shape,
colors: ButtonColors = ButtonDefaults.buttonColors(),
containerColor: Brush = Brush.verticalGradient(listOf(colors.containerColor, colors.containerColor)),
containerColor: Color = DoraColorTokens.G7,
elevation: ButtonElevation? = ButtonDefaults.buttonElevation(),
border: BorderStroke? = null,
contentPadding: PaddingValues = ButtonDefaults.ContentPadding,
Expand All @@ -49,11 +49,11 @@ fun GradientButton(
) {
Box(
modifier = gradientModifier
.background(brush = containerColor, shape = shape)
.background(color = containerColor, shape = shape)
.padding(contentPadding),
contentAlignment = Alignment.Center,
) {
Row {
Row(verticalAlignment = Alignment.CenterVertically) {
content()
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ package com.mashup.dorabangs.core.designsystem.component.buttons

import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.text.TextStyle
import com.mashup.dorabangs.core.designsystem.theme.BtnMaxColorTokens
import com.mashup.dorabangs.core.designsystem.theme.BtnMaxRoundTokens
import com.mashup.dorabangs.core.designsystem.theme.DoraTypoTokens
Expand All @@ -27,6 +29,27 @@ object DoraButtons : ButtonType {
onClickButton = onClickButton,
)

@Composable
override fun DoraBtnMaxFullWithTextStyle(
modifier: Modifier,
containerColor: Color,
buttonText: String,
enabled: Boolean,
textStyle: TextStyle,
onClickButton: () -> Unit,
) = DoraButton(
modifier = modifier,
buttonText = buttonText,
textStyle = textStyle,
enabled = enabled,
radius = BtnMaxRoundTokens.FullButtonWidthRadius,
containerColor = containerColor,
contentColor = BtnMaxColorTokens.ContentColor1,
disabledContainerColor = BtnMaxColorTokens.ContainerColor1_Off,
disabledContentColor = BtnMaxColorTokens.ContentColor_1Off,
onClickButton = onClickButton,
)

@Composable
override fun DoraMediumConfirmBtn(
modifier: Modifier,
Expand All @@ -37,7 +60,7 @@ object DoraButtons : ButtonType {
buttonText = buttonText,
textStyle = DoraTypoTokens.caption3Medium,
enabled = true,
radius = BtnMaxRoundTokens.MediumButtonWidthRadius,
radius = BtnMaxRoundTokens.SmallButtonWidthRadius,
containerColor = BtnMaxColorTokens.ContainerColor1,
contentColor = BtnMaxColorTokens.ContentColor1,
disabledContainerColor = BtnMaxColorTokens.ContainerColor1_Off,
Expand All @@ -55,8 +78,8 @@ object DoraButtons : ButtonType {
buttonText = buttonText,
textStyle = DoraTypoTokens.caption3Medium,
enabled = true,
radius = BtnMaxRoundTokens.MediumButtonWidthRadius,
containerColor = BtnMaxColorTokens.ContainerColor2,
radius = BtnMaxRoundTokens.SmallButtonWidthRadius,
containerColor = BtnMaxColorTokens.ContainerColor1_Off,
contentColor = BtnMaxColorTokens.ContentColor2,
disabledContainerColor = BtnMaxColorTokens.ContainerColor1_Off,
disabledContentColor = BtnMaxColorTokens.ContentColor_1Off,
Expand All @@ -71,10 +94,10 @@ object DoraButtons : ButtonType {
) = DoraButton(
modifier = modifier,
buttonText = buttonText,
textStyle = DoraTypoTokens.caption3Medium,
textStyle = DoraTypoTokens.caption2Medium,
enabled = true,
radius = BtnMaxRoundTokens.FullButtonWidthRadius,
containerColor = BtnMaxColorTokens.ContainerColor1,
containerColor = BtnMaxColorTokens.ContainerColor3,
contentColor = BtnMaxColorTokens.ContentColor1,
disabledContainerColor = BtnMaxColorTokens.ContainerColor1_Off,
disabledContentColor = BtnMaxColorTokens.ContentColor_1Off,
Expand Down Expand Up @@ -111,6 +134,16 @@ sealed interface ButtonType {
onClickButton: () -> Unit,
)

@Composable
fun DoraBtnMaxFullWithTextStyle(
modifier: Modifier,
containerColor: Color,
buttonText: String,
enabled: Boolean,
textStyle: TextStyle,
onClickButton: () -> Unit,
)

@Composable
fun DoraMediumConfirmBtn(
modifier: Modifier,
Expand Down
Loading
Loading