Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge_tools: add merge-tool-error-status-on-conflict config option #4981

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

scott2000
Copy link
Collaborator

@scott2000 scott2000 commented Nov 26, 2024

Some Git merge drivers can partially resolve conflicts, leaving some conflict markers in the output file. In that case, they exit with a status between 1 and 127 to indicate that there was a conflict remaining in the file. We should support this convention as well, since it will allow many Git merge drivers to be used with Jujutsu.

https://git-scm.com/docs/gitattributes#_defining_a_custom_merge_driver

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@scott2000 scott2000 force-pushed the merge-tool-error-status-on-conflict branch from 5bc7b4d to a042e13 Compare November 26, 2024 21:02
@scott2000 scott2000 marked this pull request as ready for review November 26, 2024 21:04
Some Git merge drivers can partially resolve conflicts, leaving some
conflict markers in the output file. In that case, they exit with a
status between 1 and 127 to indicate that there was a conflict remaining
in the file. We should support this convention as well, since it will
allow many Git merge drivers to be used with Jujutsu.

https://git-scm.com/docs/gitattributes#_defining_a_custom_merge_driver
@scott2000 scott2000 force-pushed the merge-tool-error-status-on-conflict branch from a042e13 to 1b3e5cf Compare November 26, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant