cli: simplify-parents: add default revsets.simplify-parents config
#4879
+109
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuja
approved these changes
Nov 16, 2024
bnjmnt4n
force-pushed
the
bnjmnt4n/push-znxutwmkspmq
branch
from
c2c99d3
to
eea22f0
Compare
|
Wanted to get a review from @torquestomp as well, as the original implementer of this feature. |
bnjmnt4n
force-pushed
the
bnjmnt4n/push-znxutwmkspmq
branch
from
eea22f0
to
4d34e5f
Compare
FYI, I think they're out today, so you might not hear anyone for a few days. |
Looks good to me, and fwiw I would discourage this notion of "must get approval from the creator" in general. It's a great way to bottleneck changes that the community otherwise agrees with, and increases the potential cost of a contributor adding a useful feature. |
torquestomp
approved these changes
Nov 25, 2024
bnjmnt4n
force-pushed
the
bnjmnt4n/push-znxutwmkspmq
branch
from
4d34e5f
to
838d89b
Compare
This adds a new `revsets.simplify-parents` configuration option (similar to `revsets.fix`) which serves as the default revset for `jj simplify-parents` if no `--source` or `--revisions` arguments are provided.
bnjmnt4n
force-pushed
the
bnjmnt4n/push-znxutwmkspmq
branch
from
838d89b
to
ac266f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
revsets.simplify-parentsconfiguration option (similar torevsets.fix) which serves as the default revset forjj simplify-parentsif no--sourceor--revisionsarguments are provided.Checklist
If applicable:
CHANGELOG.md