-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Providing pixel fragments (Sourcery refactored) #234
base: providing_pixel_fragments
Are you sure you want to change the base?
Providing pixel fragments (Sourcery refactored) #234
Conversation
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.15%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
53a371d
to
710dea0
Compare
710dea0
to
2cb55bc
Compare
fragments = differentiable_renderer_cython.renderSceneFragments( | ||
return differentiable_renderer_cython.renderSceneFragments( | ||
scene, sigma, z_buffer | ||
) | ||
return fragments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function renderSceneFragments
refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable
)
fragments = renderSceneFragments(self, sigma, z_buffer) | ||
return fragments | ||
return renderSceneFragments(self, sigma, z_buffer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function Scene2D.render_fragments
refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable
)
fragments = self.scene_2d.render_fragments() | ||
return fragments | ||
return self.scene_2d.render_fragments() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function Scene3D.render_fragments
refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable
)
Pull Request #233 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
providing_pixel_fragments
branch, then run:Help us improve this pull request!