Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified disk sorting for more than 26 disks #523

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

ggruber
Copy link
Contributor

@ggruber ggruber commented Nov 5, 2023

so all the single letter disks (sda - sdz) appear before sdaa ...

@ggruber
Copy link
Contributor Author

ggruber commented Nov 5, 2023

@PartialVolume : what do you think about this patch?

@PartialVolume
Copy link
Collaborator

Just checking it.

@PartialVolume
Copy link
Collaborator

Looks good, puts the longer device names at the end. I don't see any issues, looks fine on my system. Puts nvme0n1 type names at the bottom if I setup some loop device such as loop31 and if I had some /dev/sda devices it would still put them at the bottom.

Screenshot_20231105_160502

@PartialVolume PartialVolume merged commit 9270eda into martijnvanbrummelen:master Nov 5, 2023
2 checks passed
@PartialVolume
Copy link
Collaborator

@ggruber The device names in the GUI are stripped of their /dev/ prefix if the device name exceeds 8 characters such is the case with /dev/loop31, /dev/nvme0n1 and /dev/sdaa. However that's not an issue, your sort code sorts on the real device name in the context rather than the GUI device name.

Looks fine :-)

@PartialVolume
Copy link
Collaborator

Presumably that's what you see on your system.

/dev/sda-/dev/sdz showing as is and sdaa-sdaz showing in the GUI without the /dev/prefix so that column alignment is preserved in the display.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants