PDF_Gen37_single_column_smart_data #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously smart data was completely located on page 2 in two columns using a variable width font. This had two issues. The font size had to be very small to fit on the page which made it difficult to read and variable width fonts were used because the smart attribute table took up too much width when all the data was displayed in two newspaper type columns. This made the smart attribute table look messy. This patch now displays the smart data over page two and three in mono spaced font and with a larger font size so it's easier to read and the columns with the smart attribute table are now aligned correctly. In terms of the code, I placed the header and footer creation code in it's own function as this is called multiple times and will make it easier to add additional information pages in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously smart data was completely located on page 2 in two columns using a variable width font. This had two issues. The font size had to be very small to fit on the page which made it difficult to read and variable width fonts were used because the smart attribute table took up too much width when all the data was displayed in two newspaper type columns. This made the smart attribute table look messy.
This patch now displays the smart data over page two and three in mono spaced font and with a larger font size so it's easier to read and the columns with the smart attribute table are now aligned correctly.
In terms of the code, I placed the header and footer creation code in it's own function as this is called multiple times and will make it easier to add additional information pages in the future.