Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added lifetime parameters to all the writing systems #146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sapient-cogbag
Copy link

I don't think this is a breaking change as far as I am aware.

…can write to arbitrary string refs and such - also bumped version (do not think this is a breaking change? all the tests compiled. nyaa
@codecov-io
Copy link

Codecov Report

Merging #146 into master will decrease coverage by 0.46%.
The diff coverage is 31.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
- Coverage   94.95%   94.49%   -0.47%     
==========================================
  Files          15       15              
  Lines        1783     1797      +14     
==========================================
+ Hits         1693     1698       +5     
- Misses         90       99       +9     
Impacted Files Coverage Δ
src/write/encoder_string_writer.rs 62.26% <21.42%> (-15.24%) ⬇️
src/write/encoder.rs 88.59% <100.00%> (+0.10%) ⬆️
src/read/decoder_tests.rs 98.32% <0.00%> (ø)
src/decode.rs 92.70% <0.00%> (+0.27%) ⬆️
src/encode.rs 99.00% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4fc913...b5fe823. Read the comment docs.

@marshallpierce
Copy link
Owner

Thanks; I will look into this as soon as I can.

@marshallpierce
Copy link
Owner

Can you help me understand the use case for this? Since Write is implemented for &mut Write, why do we need to add lifetimes to make it reference-friendly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants