[MISC] Fix compilation on python3.10, correct workflow file for python3.10, fix pre-commit-config.yaml + github CI #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikoskoukis-slamcore
force-pushed
the
develop
branch
from
efe5dc8 to
87a2f82
Compare
This solves the following issue: ``` TypeError: entry_points() got an unexpected keyword argument 'group' ``` This comes due to an old implementation of `importlib` and specifically when I'm running my app inside a virtual environment. Attempts to `pip3 install --force-reinstall importlib`, inside the virtualenv, did not work since it seems that `importlib` is brought from the standard python distribution regardless of whether the environment is sourced or not. To accommodate running the app inside and outside a virtualenv I'm instead depending on `importlib_metadata` which seems to resolve the aforementioned issue.
nikoskoukis-slamcore
force-pushed
the
develop
branch
from
3bb545e to
53f87ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundling a few small commits into the same PR
pre-commit-config.yaml