Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link #30

Merged
merged 3 commits into from
Oct 8, 2023
Merged

Fix link #30

merged 3 commits into from
Oct 8, 2023

Conversation

ACCakut
Copy link
Contributor

@ACCakut ACCakut commented Oct 8, 2023

Link did not work from repo's home (https://github.com/markrossington/sidewinder-x2-marlin), just from file tree (https://github.com/markrossington/sidewinder-x2-marlin/blob/main/README.md). Now it should work anyway.

Link did not work from repo's home (https://github.com/markrossington/sidewinder-x2-marlin), just from file tree (https://github.com/markrossington/sidewinder-x2-marlin/blob/main/README.md). Now it should work anyway.
@markrossington
Copy link
Owner

Hmm relative links should be supported by GitHub. Let me have a look what I did wrong

@markrossington
Copy link
Owner

Looks like I was missing a / at the beginning of the relative link, fixed it.

@markrossington markrossington merged commit 1b2335c into markrossington:main Oct 8, 2023
@markrossington
Copy link
Owner

Nope, that didn't work, oops

@markrossington
Copy link
Owner

markrossington commented Oct 8, 2023

I don't get it, it's been supported since 2013: https://github.blog/2013-01-31-relative-links-in-markup-files/

@markrossington
Copy link
Owner

markrossington commented Oct 8, 2023

I see github/markup#1502, known bug. I gave up and used the absolute link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants