Skip to content
This repository has been archived by the owner on Jan 20, 2023. It is now read-only.

Moved construction of view uri and download uri in crud type getters #3

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

maeisabelle
Copy link

This is now ready for code review. I moved the construction of view and download uri in the crud type getters.

@grtjn
Copy link
Contributor

grtjn commented May 8, 2019

Great stuff, clean and simple. I wonder if it makes sense to push this even further down into CrudApi though, to really wrap all knowledge about the api inside those helper libs (which we might eventually expose as shared client libs for vue and react via grove-core-api). @patrickmcelwee and @mariannemyers wdyt?

@grtjn grtjn requested review from grtjn and mariannemyers August 13, 2019 08:07
@grtjn grtjn changed the base branch from master to development January 17, 2020 17:43
@grtjn
Copy link
Contributor

grtjn commented Jan 17, 2020

I am wondering, it would be even nicer if view/download url knowledge would be pushed down even further, and provided out of the box as part of metadata or such. State should keep a copy of the metadata around, so it can pull view/download uri out of them..

@maeisabelle something you'd like to play with? Would involve touching grove-node a little..

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants