Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first pass #3

Merged
merged 18 commits into from
Oct 29, 2023
Merged

first pass #3

merged 18 commits into from
Oct 29, 2023

Conversation

markhuot
Copy link
Owner

@markhuot markhuot commented Oct 29, 2023 •
edited
Loading

  • rename to withContext
  • component.getContext() should query all parents for context too and merge it in
  • remove with property from SlotDefinition and implement render, which returns markup and takes a context. Have to leave __toString for places render is not called. Render should call nested SlotCollection::render with context too

@markhuot markhuot merged commit 5cafc0f into main Oct 29, 2023
4 checks passed
@markhuot markhuot deleted the element-queries branch October 29, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@markhuot