Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix emtbView.mc #7

Open
wants to merge 1 commit into
base: master-release-1.2.0
Choose a base branch
from

Conversation

cyberman54
Copy link

No description provided.

@cyberman54
Copy link
Author

bugfix emtbView.mc

Copy link
Owner

@markdotai markdotai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi :) I don't use GitHub much so not sure if reviewing this is the right thing to do ...
But I don't think this change can be correct: as if d==null, then when it tries to do !d.isConnected() it will crash (as d is null)
If this fixes something for you, then it is probably because d is never null (in your case) so it never calls bleDisconnect().
It may be a temporary fix for the Edge devices (if this is what it is for) to remove the test for !d.IsConnected(), and only test d==null. But that won't be valid for non-Edge devices. We could upload a temporary version of the app just for Edge devices to the Garmin app store though if it is useful for you?

@cyberman54
Copy link
Author

Thanks for your reply. Indeed it's for edge, because i found that the original code disconnects immediately on Edge after connect. That's why i changed it, but obviously without overlooking the whole thing. What's the Edge specific behaviour here?

@markdotai
Copy link
Owner

I assume the Edge behavior is broken currently due to the firmware bug: https://forums.garmin.com/developer/connect-iq/i/bug-reports/bluetooth-ciq-datafield-break-in-fw-9-1 and when that is fixed then it will work ok again.
But if it isn't getting any results returned from scanning (due to the firmware bug) I'm not sure how it is getting to that idle state, and checking if the connection is lost.
Did you revert to an earlier firmware in order to get it to connect?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants