Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to_csv param 'get_params' for **kwargs #290

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Change to_csv param 'get_params' for **kwargs #290

merged 2 commits into from
Feb 19, 2024

Conversation

maread99
Copy link
Owner

Loses 'get_params' parameter from PricesBase.to_csv in favor of accepting **kwargs (change made possible by valimp now supporting *args and **kwargs).

Also adds to_csv to other_prices_methods.ipynb tutorial.

Also updates dependencies.

@maread99
Update dependencies
81f2aad
@maread99
Change to_csv param 'get_params' for **kwargs
ee40de4 
Also adds `to_csv` to `other_prices_methods.ipynb` tutorial.
@maread99 maread99 added documentation Improvements or additions to documentation code improvement Efficiency improvement, efficacy unchanged (refactoring, speed improvements etc) dependencies Pull requests that update a dependency file labels Feb 19, 2024
@maread99 maread99 merged commit 16e79bf into master Feb 19, 2024
7 checks passed
@maread99 maread99 deleted the to-csv-kwargs branch February 19, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code improvement Efficiency improvement, efficacy unchanged (refactoring, speed improvements etc) dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maread99