Add PricesBase.to_csv to export prices to csv, also various fixes
#286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Captures `FutureWarning` raised by `yahooquery` whilst fix pending merging and release (dpguthrie/yahooquery#262).
Fixes bug in `PricesYahoo` when requesting data from around the left limit. Currently behaviour is flaky where will sometimes return and sometimes not. This fix advances the effective left limit to the earliest minute for which it appears that behaviour is consistent, i.e. from where always returns data as expected. Introduces `limit_intraday_bi` and `limit_intraday_bi_calendar` methods to `PricesBase`.`limit_intraday_bi` overriden on `PricesYahoo` to provide for fix. This also provides for unifying the intraday limit as defined within `PricesBase.GetPricesParams` and as defined by `PricesBase.limit_intraday`. Includes tests for all new methods, including `PricesYahoo.limit_intraday_bi`. Also corrects `PricesIntradayUnavailableError` message for when last available minute is a close.
Preemptively sleeps workflow between publishing and installing. Also removes `i` counter from while loop (loop was failing) on incrementing `i`.
Abstracts away verification of a local directory path to valimp.
Adds `to_csv` method to `PricesBase` to provide for exporting data to .csv files. Adds test `test_base_prices.test_to_csv` and associated resources files. Also fixes `PricesBase.GetPricesParams.intraday_limit_right` to respect session closes. Also fixes PricesCsv: * to prevent attempts to request data when using .csv files containing data within one interval of 'now', for example daily data that includes a price for 'today' before today's session closes. In support of this fix: * adds 'source_live' parameter to `data.Data` and analagous SOURCE_LIVE class parameter to `PricesBase`. * adds `test_csv.test_not_live` to verify behaviour. * to not try to get tables for unaligned intervals.
maread99
added
enhancement
maread99
force-pushed
the
to-csv
branch
3 times, most recently
from
c119781 to
770a9a2
Compare
Fixes for new `test_to_csv` and `test_request_from_left_limit` to prevent flaky behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
PricesBase.to_csvmethod to provide for exporting data to .csv files. Adds testtest_base_prices.test_to_csvandassociated resources files.
Also:
PricesBase.GetPricesParams.intraday_limit_rightnow respects session closes.PricesCsvwith files containing data within one interval of 'now', for example daily data that includes a price for 'today' before today's session (previously would raise error on trying to re-request a live price).