fix: disable tests (doctests failure) (#95) #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosh
reviewed
Oct 9, 2024
It would take an upstream fix (my guess is If you want, I can work on a less invasive solution: disabling only doctests, or avoiding Let me know what would be better. |
Between the options, I would prefer disabling only doctests |
blackheaven
force-pushed
the
hf/nix-tests
branch
from
610a723 to
2a10073
Compare
marcosh
approved these changes
Nov 28, 2024
|
@blackheaven sorry for taking so long... |
|
No worries, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have completely disable tests (it's usually done for other haskell packages with doctests) which makes the build to pass, however, we lost nix build safety.
I can investigate further to only disable the check of the
lhsfile.