Add sensors for job queue status and queue count #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please adjust and make sure tests passes |
|
I don't know why changing the initiliazation order fixes the unit tests because I'm not familiar with the setup of this project. Can you explain why that works? |
Wow... I have no clue, that is quite wild |
marcolivierarsenault
requested changes
Jun 4, 2024
marcolivierarsenault
merged commit ff12213
into
marcolivierarsenault:main
6 checks passed
|
Thank you for your contrib |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new sensors making use of the job queue API.
One sensor is a textual representation of the current job queue status.
The other one, that initially made me think about implementing this, represents the current amount of jobs in the queue. As I programmed an automation that gracefully shuts down my printer and turns its power off, I though that there should be a way to only do that if there are no pending jobs in the printer's queue.
I am unsure about the unit tests - please advise if and how I should add one ore more tests for these sensors.