Add duration device class for total print time and longest print sensors #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@saintonotole this is a great patch, can you adjust tests for it |
saintonotole
force-pushed
the
device-class
branch
from
5e6f7cb to
854bd7f
Compare
|
@marcolivierarsenault I've adjusted the tests to match the expected data |
| value_fn=lambda sensor: convert_time( | ||
| sensor.coordinator.data["history"]["job_totals"]["longest_print"] | ||
| ), | ||
| value_fn=lambda sensor: sensor.coordinator.data["history"]["job_totals"][ |
There was a problem hiding this comment.
For the failing test you probably need to round the value
|
inactive, re-open if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a device class to the
Longest PrintandTotals Print Timehistory sensors, similar to the rest of the existing time-related sensors.The current implementation casts these sensors to plain text values, which makes it very difficult to try to build any automations on top of these values.
For example, I want to make a reminder every X hours of printing to do maintenance on the printer (lubricate the guides, check belt tension, check for debris in the extruder, and so on).
This could also be useful for people with print farms to more easily keep track of printer wear and tear and to more evenly distribute print jobs.