Add port to camera and thumbnail URL

[michael-fritzsch]

Hi @marcolivierarsenault,

thanks for creating this nice Home Assistant integration! I noticed that I had to add the moonraker port to both camera URLs (camera and thumbnail).

I didn't fully work my way through the tests. Would a change to the tests be required for this change?

[marcolivierarsenault]

Hey 1 thanks a lot for the contribution.

Have you tried to put a url that includes a port in the original setup?

exemple:

http://1.2.3.4:123

[michael-fritzsch]

Hi @marcolivierarsenault,

When adding a new printer to the integration, the setup screen looks like this:

I, as a user, don't get the idea to add a URL, because there are two fields asking for host and port, separately.

Or do you refer to the integration's "configure" screen show below? Yes, there I had to add the full URL including port. With this PR's change applied, the camera works without explicit configuration.

[michael-fritzsch]

Oh sorry, @marcolivierarsenault. Now, I newly re-added the printer to the integration again to be fully sure. In my case, the camera streams runs on a different port than the moonraker API (see screenshots above). So in my case, I have to set the configuration entry manually.

When I tested this change, I was fooled by Homeassistant as it seems to have properly cached/saved the manual configuration somehow, while I thought I was starting with a clean device integration. Sorry for this!

Reading more through the monnraker documentation, I now understand that camera streams basically always run independent of moonraker on another port, so we shouldn't use the monnraker port as a default here. I didn't get that basic concept earlier. So closing this PR as being incorrect. Thanks for your helpful question 😄