lower the object when accessing the configfile.settings object for ou… #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcolivierarsenault
approved these changes
Nov 25, 2023
…tput_pin On some device, notably the creality k1, some output_pin configuration are capitalized. When reading the configfile.settings object those same configuration are in lower case, make sure to always check with the lower string for output_pin
cashew22
force-pushed
the
bugs/fix-capitalize-option
branch
from
0a35e8a to
d545a8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tput_pin
On some device, notably the creality k1, some output_pin configuration are capitalized. When reading the configfile.settings object those same configuration are in lower case, make sure to always check with the lower string for output_pin
This should fix #205