Add support for TLS connections #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a toggle for connections that use TLS. this change makes it possible to access HTTPS enabled printers.
|
This is really a good idea, I will review in the next few days. |
Document the default values and add a note that TLS must be configured on the server side for them to work.
|
Sure, I added very basic documentation. There isn't all that much to say about the connection dialog and the TLS option, but having a starting point is good. |
marcolivierarsenault
approved these changes
Oct 1, 2023
marcolivierarsenault
merged commit ddaafe5
into
marcolivierarsenault:main
5 checks passed
|
Thank you @ressu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the extension only allows connecting directly to moonraker or to a relay host which doesn't use HTTPS.
This change adds support to HTTPS connections to Moonraker.