Fix failing test on Windows with Python 3.11.9+

[marcelm]

Python 3.10 is fine, but 3.11 breaks the tests. This made creating the wheels for v1.2.3 fail.

[rhpvorderman]

1.2.2 Was released but a month ago and the wheel building presumably went fine (I saw no error messages in the e-mail). I wonder what could cause this.

EDIT: The diff is not giving me any clues. This is weird. Also why would it be specific to python 3.11?

[marcelm]

Some testing in a virtual machine gives the result that the tests pass with Python 3.11.8, but fail with Python 3.11.9. The Python 3.11 version changed when I updated cibuildwheel.

[rhpvorderman]

Could it be this change? https://github.com/python/cpython/pull/116989/files

It is the only thing I find in the changelog (https://docs.python.org/release/3.11.9/whatsnew/changelog.html#python-3-11-9) that seems related.

[rhpvorderman]

Alternatively, I wonder if replacing cat with python -c 'import sys; file = sys.argv[1]; f=open(file, "rt"); text = f.read(); f.close(); sys.stdout.write(text) would solve the issue. That should work with all operating systems equally.

[marcelm]

Or maybe this one? python/cpython#95782

In any case, the problem is in _detect_format_from_content, where seekable() is true for stdin on Windows but doesn’t actually work. Not sure what the actual problem is, but preferring peek() makes the issue go away.

[rhpvorderman]

Good find! These windows-specific issues are always very tedious to solve. I am glad you found the solution relatively quickly.

[marcelm]

Version 1.2.3 is now released.