Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update marbl_ciso_interior_tendency_mod.F90 #466

Open
wants to merge 2 commits into
base: stable
Choose a base branch
from

Conversation

jlinmod
Copy link

@jlinmod jlinmod commented Jul 18, 2024

Fixed comments, eps_aq_g equation error (Zhang et al., 1995), and cell surface area unit conversion fix for calcifier (Popp et al., 1998).

Fixed comments, eps_aq_g equation error (Zhang et al., 1995), and cell surface area unit conversion fix for calcifier (Popp et al., 1998).
@mnlevy1981
Copy link
Collaborator

As in #465 (comment), line 355 was correct before you added the negative sign but if you revert that change then we'd be happy to update all of your comments.

Also note that your change to cell_surf(auto_ind) in line 836 is inside an entire block of commented-out code; as the comment mentions, we don't know these values for explicit calcifiers yet, so those autotrophs continue to use the defaults for small phytoplankton (where cell_surf(auto_ind) = 87.6e-12_r8). I would suggest reverting line 836 as well, and we'll make sure cell_surf(auto_ind) is set correctly when we are ready to use different values for all the cell_ variables for explicit calcifiers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants