Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2581 #2590

Closed
wants to merge 5 commits into from
Closed

Fixes #2581 #2590

wants to merge 5 commits into from

Conversation

adamduren
Copy link
Contributor

@wf9a5m75 here is a fix for #2581. I made it to master but can switch to multiple_maps if needed.

@wf9a5m75
Copy link
Member

wf9a5m75 commented Apr 2, 2019

All pull request must be to the multiple_maps branch please.

@adamduren
Copy link
Contributor Author

As an alternative I can remove the q library altogether. Native Promises have been supported all the way back to [email protected] which isn't even supported by Cordova anymore.

@adamduren adamduren changed the base branch from master to multiple_maps April 2, 2019 21:27
@adamduren adamduren closed this Apr 2, 2019
@adamduren adamduren deleted the fix-require-cordova-module-error branch April 2, 2019 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamduren @wf9a5m75