Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packaging of portable data for icu, gdal, and proj #750

Merged
merged 4 commits into from
Apr 8, 2017

Conversation

springmeyer
Copy link
Member

Context

We moved to using mason for dependencies in #738. Mason supports the mason link command which places symlinks of files at predictable paths. The build then copies these over into lib/binding when packaging the portable node-mapnik binaries.

The bug

The symlinks were being copied rather than the actual files. This meant that, once published, the data was missing since the symlinks were "broken" (point to non existent data).

Solution

We need to ensure this bug never happens. So this PR moves to removing the mason_packages folder before running the node-mapnik tests. This replicates the point to non existent data situation during node-mapnik travis builds.

This PR also starts passing the -L flag to cp to deference the symlinks during copy to ensure we are copying the full data and not just the symlink.

@codecov-io
Copy link

codecov-io commented Apr 8, 2017

Codecov Report

Merging #750 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #750   +/-   ##
=======================================
  Coverage   96.23%   96.23%           
=======================================
  Files          42       42           
  Lines        8772     8772           
=======================================
  Hits         8442     8442           
  Misses        330      330

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4e455d...1a6544c. Read the comment docs.

@springmeyer springmeyer merged commit 12b70b8 into master Apr 8, 2017
@springmeyer springmeyer deleted the mason-fix branch April 8, 2017 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants