Fix packaging of portable data for icu, gdal, and proj #750
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We moved to using mason for dependencies in #738. Mason supports the
mason link
command which places symlinks of files at predictable paths. The build then copies these over intolib/binding
when packaging the portable node-mapnik binaries.The bug
The symlinks were being copied rather than the actual files. This meant that, once published, the data was missing since the symlinks were "broken" (point to non existent data).
Solution
We need to ensure this bug never happens. So this PR moves to removing the
mason_packages
folder before running the node-mapnik tests. This replicates thepoint to non existent data
situation during node-mapnik travis builds.This PR also starts passing the
-L
flag tocp
to deference the symlinks during copy to ensure we are copying the full data and not just the symlink.