Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix actor flaky test #5102

Merged
merged 2 commits into from
Nov 24, 2024
Merged

Fix actor flaky test #5102

merged 2 commits into from
Nov 24, 2024

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Nov 24, 2024

Launch Checklist

This is in continue to the following PR to fix a flaky test:

It also simplifies the test initialization.

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.81%. Comparing base (3f1686e) to head (9dc8435).
Report is 1 commits behind head on main.

❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format.

Additional details and impacted files
@@            Coverage Diff            @@
##             main    #5102     +/-   ##
=========================================
  Coverage   91.80%   91.81%             
=========================================
  Files         279      279             
  Lines       38332    38332             
  Branches     4999     6696   +1697     
=========================================
+ Hits        35192    35194      +2     
+ Misses       3007     3006      -1     
+ Partials      133      132      -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@birkskyum
Copy link
Member

Thanks, that's the better solution compared to a retry

@birkskyum birkskyum merged commit 17f04d7 into main Nov 24, 2024
17 checks passed
@birkskyum birkskyum deleted the fix-actor-flaky-test branch November 24, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants