feat: add allow-overlap for symbols #507
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsmagnus
changed the title
Zverik
suggested changes
Oct 3, 2024
| addIfPresent('icon-ignore-placement', iconIgnorePlacement); | ||
| addIfPresent('icon-optional', iconOptional); | ||
| addIfPresent('icon-rotation-alignment', iconRotationAlignment); | ||
| addIfPresent('icon-size', iconSize); | ||
| addIfPresent('icon-allow-overlap', iconAllowOverlap); |
There was a problem hiding this comment.
It doesn't look like you needed to change this file — all properties were already there.
| @@ -13,7 +13,6 @@ dependencies: | |||
| sdk: flutter | |||
| maplibre_gl_platform_interface: ^0.20.0 | |||
| maplibre_gl_web: ^0.20.0 | |||
|
|
|||
| @@ -165,6 +174,10 @@ class SymbolOptions { | |||
| } | |||
| } | |||
|
|
|||
| addIfPresent('iconOptional', iconOptional); | |||
| addIfPresent('iconIgnorePlacement', iconIgnorePlacement); | |||
| addIfPresent('iconOptional', iconOptional); | |||
| dependencies: | ||
| flutter: | ||
| sdk: flutter | ||
| flutter_web_plugins: | ||
| sdk: flutter | ||
| image: ^4.0.17 | ||
| js: ">=0.6.7 <0.8.0" | ||
| maplibre_gl_platform_interface: ^0.20.0 | ||
| maplibre_gl_platform_interface: | ||
| path: ../maplibre_gl_platform_interface |
There was a problem hiding this comment.
Changing this file doesn't seem in scope for the PR.
There was a problem hiding this comment.
The project uses melos to orchestrate its packages.
dart pub global activate melos
melos bootstrapThis will resolve the dependencies so that no changes to pubspec.yaml are necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, i think this adds support for a symbol-options: icon-allow-overlap, icon-optional and icon-ignore-placement.
I am not sure i have gotten all these correct, so if someone could verify I would appreciate it. Thanks 🙏