-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add docusaurus #461
docs: add docusaurus #461
Conversation
This reverts commit 8743b71.
Not sure how to fix the dependency review CI. Error: $GITHUB_STEP_SUMMARY upload aborted, supports content up to a size of 1024k, got 1975k. The markdown summary exceeds the maximum size. Maybe because docusaurus adds too many dependencies at once? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I'm not sure if keeping all the docs for every version is a proper way to go, but why not. From the instructions, it is also not clear how to edit docs for an earlier version, for example.
This way it's possible to edited or improve old documentation as well as edit the latest version.
Not sure how much documentation should get copied over from the docusaurus docs. They have documentaiton about versioned docs at https://docusaurus.io/docs/versioning. For users that just want to fix a typo or similar there is always the "Edit this page" button on every docs page. |
I'm using this documentation page on the new maplibre package but if wanted we can still include it into this project, too. |
Some additional notes: maplibre-gl-js had a discussion about the "right" static site generator in maplibre/maplibre-gl-js#2150. In the end it's probably comes down to personal preference. I decided to go with docusaurus when creating this pr because of some features like versioned docs, an awesome site search and so on. As all documentation is in markdown, it would be possible to go with an other site generator, too. The scope of this pull request is to provide a basic documentation setup. Adding full documentation is out of scope. Because many npm dependencies are added in this pr, the Dependency Review CI fails. |
Closing off this pull request now... |
This pull request
A preview can be viewed here: https://josxha.github.io/flutter-maplibre-gl/