-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: missing render when coming back from background #364
base: main
Are you sure you want to change the base?
Conversation
Copy from [commit on google maps library](flutter/packages@e393d45)
PostInvalidate ensures invalidation to run on UI thread
I just copied the code from the google maps plugin but in fact we just need to invalidate the texture view, not all the mapview |
Thanks for contributing! It would be good if some more people who had the issue could test this approach and comment here, since I can't reproduce the original issue. |
I tried on my Samsung Note8 (SM-N950F - Android 9) and the fix is working great ! |
I can still reproduce the bug on my phone. |
I can not reproduce this, can you let me know under which conditions this appears? |
What i've done to test:
For me the bug is still reproduceable on Android 9 and Android 14 even with your changes
|
What
Fix issue #327
Copied from commit on the google map flutter plugin.
The commit concerned was fixing another fix that has inserted a second bug.
Test Plan
Tested on emulator API 28 & samsung Galaxy s7-> no more rendering missed when come back from background
Tested on OnePlus 7T android 12 -> no regression seen
Maestro Flow to reproduce bug
Run this flow with the following command:
maestro test path_to_the_file
Careful the flow does not check if the bug is present, just follow the steps to reproduce 15 times.