Release v5.0.2 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…34) (#265) * feat: add isCollateralMaintained check in makePayment() * feat: Add test for collateralNotMaintained for makePayment * feat: Update test based on JGs suggestion - Expose collateral not maintained check when using drawable funds only * fix: Update based on PR comments * feat: Update test to include collateralAsset and calc for collateral requirement * refactor: Move mint of collateral asset
* feat: set lender during initialization * fix: update globals mock * fix: update mocks and add missing tests * fix: address all pr comments * fix: update spacing Co-authored-by: lucas-manuel <[email protected]>
* fix: update to not accrue interest into the next payment interval when the loan is late on a refinance * feat: Test to ensure late loan refi interest calculated correctly * feat: Add literal assertions for interest amounts * fix: Update based on PR comments * fix: update params Co-authored-by: Lucas Manuel <[email protected]>
* feat: enable borrower to perform upgrades * fix: update error message * fix: address PR comments * fix: update failing upgrade pause test
* feat: rename lateInterest var * fix: name
* fix: internal audit findings * ci: update coverage threshold --------- Co-authored-by: lucas-manuel <[email protected]>
* feat: update to use isInstanceOf in leiu of isFactory * feat: update key * feat: update key * chore: update var name
* feat: add V5 migrator and tests * fix: missing word on comment * test: remove loan v4 mock * fix: update rates in tests as well as use scaled precision in payments calc * fix: tests after rate change * test: added test for initializer * fix: adjust PR comments --------- Co-authored-by: lucas-manuel <[email protected]>
* feat: globals `isFunctionPaused` (sc-11842) * feat: remove `isFactory` * feat: add pause on migrate and setImplementation * refactor: undo function reordering --------- Co-authored-by: 0xfarhaan <[email protected]>
* fix: underscore syntax [3S #9] (SC-12033) * refactor: cleanup --------- Co-authored-by: Lucas Manuel <[email protected]>
* fix: make change and fix tests * fix: account origination fees into assertions --------- Co-authored-by: lucas-manuel <[email protected]>
* refactor: reorder * refactor: interfaces cleanup * fix: update formatting --------- Co-authored-by: lucas-manuel <[email protected]>
* feat: only securityAdmin can upgrade loan * style: remove extra _ * fix: update test name Co-authored-by: Michael De Luca <[email protected]> --------- Co-authored-by: Lucas Manuel <[email protected]> Co-authored-by: Michael De Luca <[email protected]>
* fix: make hundred percent public * test: add test for getter
* refactor: rename to lateInterestPremiumRate * refactor: update var name in tests * fix: pr review --------- Co-authored-by: Michael De Luca <[email protected]> Co-authored-by: Lucas Manuel <[email protected]>
… (#296) * feat: clean up impairment removal (SC-12191) (SB #22) * fix: update events --------- Co-authored-by: JG Carvalho <[email protected]> Co-authored-by: Lucas Manuel <[email protected]> Co-authored-by: lucas-manuel <[email protected]>
* fix: delete refinance commitment on clear accounting * fix: also clear refinance interest * test: add assertion on clear loan
* chore: cleanup and bytecode size check (SC-12382) * fix: coverage report and size check script
* feat: update factory to include canDeploy (sc-13704) * fix: add err msg --------- Co-authored-by: 0xfarhaan <[email protected]>
* feat: create loan migrator to update factory on loan (SC-13705) * feat: add isLoan update function (SC-13705) * feat: unit tests (SC-13705) * fix: overload isLoan (SC-13705) * fix: test file name (SC-13705) * fix: comments (SC-13705) * refactor: update tests and formatting on contracts * fix: comment * chore: address PR comments --------- Co-authored-by: 0xfarhaan <[email protected]>
This reverts commit 6e86c75.
LCOV of commit
|
LCOV of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.