Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace calls to getWindow with a simpler check #216

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Conversation

chriswhong
Copy link
Contributor

Removes the util getWindow() which was causing issues with SSR in docs sites (closes #210)

@chriswhong chriswhong marked this pull request as ready for review September 19, 2023 21:20
Copy link
Member

@tristen tristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chriswhong chriswhong merged commit c3ac6a4 into main Sep 19, 2023
4 checks passed
@chriswhong chriswhong deleted the remove-get-window branch September 19, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calls to getWindow() prevent successful use in SSR
2 participants