Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump mapbox gl js to v3, replace Streets with Standard #875

Merged
merged 1 commit into from
Jan 31, 2024
Merged

bump mapbox gl js to v3, replace Streets with Standard #875

merged 1 commit into from
Jan 31, 2024

Conversation

chriswhong
Copy link
Contributor

image

OdNairy
OdNairy approved these changes Jan 31, 2024
View reviewed changes
Copy link

@OdNairy OdNairy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chriswhong for an update!

package-lock.json
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it expected that npm ci command fails without --force flag?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2024-01-31 at 09 48 50@2x

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember the same gl-geocoder dependency issue popping up when v3 came out. Yes, this is expected until we bump the version on mapbox-gl-geocoder. I'll get to it soon along with some other dependencies.

wboykinm
wboykinm reviewed Jan 31, 2024
View reviewed changes
Copy link
Contributor

@wboykinm wboykinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like a good sign for the dev experience if this is what's required to go from v2 to v3 and streets to standard. The modularity is really straightforward. 🤘

@chriswhong chriswhong merged commit 2098fb3 into main Jan 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wboykinm wboykinm wboykinm left review comments

@OdNairy OdNairy OdNairy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chriswhong @OdNairy @wboykinm