Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is normalize not an option for inverse_haversine? #76

Open
thillerson opened this issue Nov 26, 2024 · 3 comments
Open

Why is normalize not an option for inverse_haversine? #76

thillerson opened this issue Nov 26, 2024 · 3 comments

Comments

@thillerson
Copy link
Contributor

Am I misunderstanding something? It seems like normalizing the output of inverse_haversine is important. Is there a reason why normalizing to between [-90, 90] latitude and [-180, 180] longitude isn't an option?

@jdeniau
Copy link
Member

jdeniau commented Nov 26, 2024

Hi @thillerson , this just has not been implemented.

The implementation of normalize was made in #52 , but inverse_haversine is a different function and has not been implemented.

If you are willing to open a PR, I will accept that 👍

@thillerson
Copy link
Contributor Author

@jdeniau Ok, good, I was worried I was missing something. I will try to submit something within a few days.

@thillerson
Copy link
Contributor Author

@jdeniau Ok, I tried again with #78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants