Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option to normalize output of inverse_haversine #77

Conversation

thillerson
Copy link
Contributor

Comportement actuel

inverse_haversine across the international dateline would return invalid longitude

Nouveau comportement

inverse_haversine now has an option to normalize the output points
See also: #76

@thillerson
Copy link
Contributor Author

I'm sorry, it seems like a lot of formatting changes came across in the PR also. I will try to fix these later.

@jdeniau
Copy link
Member

jdeniau commented Nov 27, 2024

I'm sorry, it seems like a lot of formatting changes came across in the PR also. I will try to fix these later.

Thanks, because it's impossible to review on my phone here!

If the formatting is related to a PEP stuff, we might fix this in another PR (or use https://github.com/psf/black that see s to be the equivalent of prettier for python?)

@thillerson thillerson closed this Nov 27, 2024
@thillerson
Copy link
Contributor Author

Closed, in order to try again with no formatting noise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants