-
-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Individual Layer Flipping #10
Open
xervon
wants to merge
40
commits into
manna-harbour:miryoku
Choose a base branch
from
xervon:layer_flip
base: miryoku
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8755)" This reverts commit 89dbc18.
Individual commits can be found at https://github.com/manna-harbour/miryoku_qmk/commits/miryoku-20220227 - Add FUNDING.yml - Update root readme - Remove files from .github - Add workflows - Add custom_config.h and custom_rules.mk to workflows - Override local custom_rules.mk and custom_config.h in workflows - Add merge field to workflows
- Update BT keycodes on Media inner index: - Move OUT_AUTO to bottom row - Move RGB_TOG in vi to pinkie column to match other TOG keycodes, and rotate row
- Supports adding and removing layers from custom_config.h - Add "U_" prefix to layer names - Add layer name strings - Populate keymaps array from X macro - Populate layers enum from X macro - Move layers enum to manna-harbour_miryoku.h - Rename miryoku_alternatives.h to miryoku_layer_alternatives.h - Rename miryoku_layer.h to miryoku_layer_selection.h - Remove miryoku_layer_names.h - Add miryoku_layer_list.h
Add support for uf2 firmware
Combine with Shift for Caps Lock
Remove ferris, covered community layout
…layout options Add Test Inputs workflow with all text fields for matrix builds
…options Add Test Inputs workflow with all text fields for matrix builds
manna-harbour
force-pushed
the
miryoku
branch
from
November 29, 2022 02:53
5ca8c1c
to
d92f5d1
Compare
manna-harbour
pushed a commit
that referenced
this pull request
May 3, 2023
Issue #8: add ffkb v3 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the user to flip individual layers.
To facilitate this, I
MIRYOKU_LAYERS
toFLIP_$LAYER
(e.g.MIRYOKU_LAYERS=FLIP_SYM
)MIRYOKU_THUMBKEYS_LAYER
, that$THUMBKEY=$LAYER
(e.g. LO=MEDIA)I've also added an additional parameter
MIRYOKU_THUMBKEYS_KEYCODE
that allows the user to rebind the thumb keys. This parameter accepts a comma-separated list of values of the form$THUMBKEY=$QMK_KEY_CODE
.At the same time, this change allows decoupling the flipping of layers from the flipping of layer change keys. If a user wishes to use the same hand for switching to a layer (to facilitate one-handed media control for example), this is now possible.
Further this also simplifies using the thumb keys in combos since all thumbkey bindings are now defined as
MIRYOKU_THUMBKEY_$THUMBKEY
for the Layer-Tap binding andMIRYOKU_THUMBKEY_$THUMBKEY_KC
for the Tap binding.Following an example configuration (
custom_rules.mk
)This flips the media layer while keeping all other layers and the thumb keys in normal order. It also switches the bindings for the
MEDIA
andMOUSE
layers and switches Backspace and Delete.