Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google sign in with some warning changes #265

Closed
wants to merge 9 commits into from

Conversation

akankshagoel28
Copy link

Firstly I have added the google button on the sign in page, i also made some changes in the naming to get a clear idea and made some changes for I was getting a lot of warnings on my terminal, there are still a lot of warnings, if you want i will create a new issue for that

Copy link

vercel bot commented Oct 10, 2024

@akankshagoel28 is attempting to deploy a commit to the ommaniya70's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@akankshagoel28

Thank you for your Pull Request!

We truly appreciate your contribution! 🙌
We will review the changes and provide feedback or merge the PR soon. 🔍
Please stay tuned for updates! 🔔

🌟 Thank you for your efforts in improving the project! 🙏

@maniyaom
Copy link
Owner

@akankshagoel28 Why you have modified other pages also? You just have to work on your assigned task only.

Raise new PR and modify only assigned page (Login page).

Note: Work on latest repository

@akankshagoel28
Copy link
Author

there were a lot of warnings when i ran the repo that is why, i changed the name since i thought it would be easier to understand

@maniyaom
Copy link
Owner

@akankshagoel28 why you modified these files?

Ignore the warnings and modify just login and signup page. You can modify signup page only if it is required.

also, Do you also want to work on Forgot Password issue?

@akankshagoel28
Copy link
Author

alright i will work on those issues and modify only the login page with the forgot password feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants