Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Added Form Tags to Login and Signup, Modularized Repeated Components #197

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lakshyeahh
Copy link

@lakshyeahh lakshyeahh commented Oct 7, 2024

PR Description: for Issue #198

Earlier:

  • Both the login and signup components had hardcoded input fields without proper form tags for handling form submission.
  • Repeated input components such as email, password, and text fields were directly written in each form, leading to code duplication.

Changes:

  • Added <form> tags to both login and signup components to handle form submission correctly.
  • Modularized the code by creating reusable input components (TextInput, PasswordInput) and replaced the repeated input fields with these components.

Effect:

  • Improved code readability and maintainability by removing code duplication.
  • Easier to scale and modify the input fields across the app, ensuring consistency in styling and behavior.
  • Proper form submission handling with better structure and validation.

Copy link

vercel bot commented Oct 7, 2024

@lakshyeahh is attempting to deploy a commit to the ommaniya70's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Oct 7, 2024

@lakshyeahh

Thank you for your Pull Request!

We truly appreciate your contribution! 🙌
We will review the changes and provide feedback or merge the PR soon. 🔍
Please stay tuned for updates! 🔔

🌟 Thank you for your efforts in improving the project! 🙏

@maniyaom
Copy link
Owner

maniyaom commented Oct 9, 2024

@lakshyeahh It looks like you were not working on the latest version of the repository. Because of this, some features contributed by others were removed in your update. Also, the .env file, which contained sensitive information, was reintroduced even though it had been removed for security reasons.

@lakshyeahh
Copy link
Author

Noted sir. Should i proceed with the changes in the most recent version of the project. Because it is the best practice to use a form tag exp for forms, gives more readability and will help in code expansion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants