Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for mixed items OR rule as documentation #100

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

johnnyshankman
Copy link
Contributor

@johnnyshankman johnnyshankman commented Dec 24, 2024

This PR

I found it unclear what is expected for the scenario I've outlined in this unit test:

AND STEP 0:
  BURN 3x of any token on some 1155 contract
     OR
  BURN 1x of someERC721
AND STEP 1:
  BURN 1x of token id 2 on some 1155 contract

the answer is that the 1155 token is not repeated 3 times in burn tokens, instead it is added just one and mapped to the burn item that has amount set to 3x.

Self-Review

  • Review and comment PR file changes
  • Description provides context for the changes
  • Tests are included for the PR (required on server changes)

Copy link

github-actions bot commented Dec 24, 2024

LCOV of commit dbd7b01 during Test! #439

Summary coverage rate:
  lines......: 55.3% (1573 of 2846 lines)
  functions..: 59.5% (238 of 400 functions)
  branches...: 37.3% (301 of 807 branches)

Files changed coverage rate: n/a

@johnnyshankman johnnyshankman merged commit e2be17d into main Dec 31, 2024
7 checks passed
@johnnyshankman johnnyshankman deleted the johnny/unit-test-or-with-mixed-specs branch December 31, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant