Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmray: record command line info #2515

Merged
merged 3 commits into from
Dec 3, 2024
Merged

vmray: record command line info #2515

merged 3 commits into from
Dec 3, 2024

Conversation

mr-tz
Copy link
Collaborator

@mr-tz mr-tz commented Dec 2, 2024 •
edited
Loading

example results afterwards:

image

image

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

mike-hunhoff
mike-hunhoff requested changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@mike-hunhoff mike-hunhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and nice addition! Just one quick question for you to review.

capa/features/extractors/vmray/__init__.py Outdated Show resolved Hide resolved
@mr-tz mr-tz force-pushed the vmray/record-cmdline branch from 7a8551b to c37eaca Compare December 2, 2024 16:59
@mr-tz mr-tz force-pushed the vmray/record-cmdline branch from c37eaca to bbe2223 Compare December 2, 2024 17:03
mike-hunhoff
mike-hunhoff approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@mike-hunhoff mike-hunhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mr-tz mr-tz merged commit d1f3e43 into master Dec 3, 2024
27 checks passed
@mr-tz mr-tz deleted the vmray/record-cmdline branch December 3, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williballenthin williballenthin williballenthin approved these changes

@mike-hunhoff mike-hunhoff mike-hunhoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mr-tz @williballenthin @mike-hunhoff