-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict signature debug logging to vivisect backend #2044
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
f182641
to
16b0248
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see inline comment, then good to go
16b0248
to
21b8edf
Compare
21b8edf
to
c695b37
Compare
is this good? thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
I noticed that signatures will only load when the backend is vivisect:
capa/capa/main.py
Lines 695 to 698 in 7debc54
I moved the debug logging from
handle_common_args
toget_signatures_from_cli
, so it's only printed when the signatures are actually used. This means that other backends don't need the default signatures directory to exist.Closes #1875
Checklist